Convert Navbar Plugin to Phyton3

DJ eXo · Jan 4th 2025

Hello dear community,

In a project we are trying to conventionize a plugin designed for Phyton2 to Phyton3. We are so far that the plugin appears in the extension list, but there are still 3 errors when starting it.

It is the Navibar plugin. A fancy plugin selection bar or selection list. The images are from the original Py2 plugin. I attach the current status as a file attachment.

Py3 modded: navibar.tar.xz.tar

Py2 original: Navibar original Py2.zip

screenshot (1).png Navibar_4.jpg Navibar_1.jpg

I am grateful for any help!

**KiddaC** · Jan 5th 2025

A few quick tips.

python 3
print statements need to be wrapped in brackets. Check all print statements in the python files.

print blah
becomes
print(blah)

The indentations are all over the show. A mixture of tabs and spaces. This will fail.
Don't use tabs anymore. Use 4 spaces for a tabbed indents
Use a text editor like notepad++ to replace all tabs with 4 spaces. Then check all the indentation are lined up correctly.

Remove commented out code

Remove unused imports.
i.e
from Components.AVSwitch import AVSwitch
avswitch has been depreciated in most modern oe-alliance images.
You don't use it in the code anyway

always have a space after a # comment.
#wrong
# right

Check only 1 blank line between def functions

You can also use chatgpt to assist you nowadays.
Although you are character limited in chatgpt, . About 450 lines of code. so you have to do it in sections or groups of functions.

i.e
"Can you format this code to pep8"

"the following code snippets I am going to post are for enigma2 plugin. The code needs to be compatible with python 2.7 and python 3.*. Can you check the code. I will post them in sections."

blah blah blah

**KiddaC** · Jan 5th 2025

the dirSelect.py is pretty clean.
Here are a few minor amends to it

**KiddaC** · Jan 5th 2025

some examples of pep8 formatting errors my software has flagged.

pasted-from-clipboard.png

But if you don't try to fix it yourself. You will never learn.

mrvica · Jan 5th 2025

not easy to get used to it

tell me if I am wrong? on GIT they still use tabs

enigma2/lib/python at develop · OpenPLi/enigma2 · GitHub

enigma2/lib/python at 7.4 · openatv/enigma2 · GitHub

**Lululla** · Jan 5th 2025

my contribute for it

overwrite plugin.py in folder

**Lululla** · Jan 5th 2025

I was trying the plugin and I noticed that it didn't work on pli image, so after a few crashes I fixed it.

The only problem, but I didn't investigate, is that I don't see the icons, only the info bar and the frame that moves in addition to the descriptions.

old code

Code

            args = inspect.getargs(p.__call__)[0]
            if not len(args) != 1 or len(args) == 2 and isinstance(InfoBar.instance, InfoBarChannelSelection):
                lx.append(((boundFunction(self.getPluginName, p.name), boundFunction(
                    self.runPlugin, p), lambda: True), None, p.name))

i have fixed with this code.

Python

            if hasattr(p, '__call__') and callable(p.__call__):
                from inspect import signature
                try:
                    args = list(signature(p.__call__).parameters.keys())
                except ValueError:
                    # Se non riesce a ispezionare, supponiamo che non abbia argomenti
                    args = []
            else:
                args = []
            if len(args) in (1, 2) and (len(args) == 1 or isinstance(InfoBar.instance, InfoBarChannelSelection)):
                lx.append(((boundFunction(self.getPluginName, p.name), 
                            boundFunction(self.runPlugin, p), 
                            lambda: True), 
                           None, 
                           p.name))

Display More

DJ eXo · Jan 6th 2025

Good work!

The image problem does not only affect the icons, various menu icons are also not displayed.

In addition, the description of the first plugin in the bar is missing after starting the plugin, it only appears after switching back and forth once. In the Phyton2 version, the description is correctly displayed directly.

Who can help?

DJ eXo · Jan 28th 2025

Any ideas?

DJ eXo · Feb 9th 2025

? Push

Convert Navbar Plugin to Phyton3

Your resource for Enigma2 softcam plugins

Participate now!

Share