Posts by Damon Chaplin

Quote from urie

Quote from Damon Chaplin

I just noticed in the Onyx skin (without the EPG mod) if I press the Record button in the Graphical EPG I get the popup menu, but 2 items are missing.

I changed o-channelselection.xml, making the RecordTimerQuestion screen have a height of 195, the "list" have a height of 180, and created a recordquestion4.png image with a height of 195. That seems to fix it.

I just tried but I do use EPG Mod seems ok here.

Your screenshot is only showing 2 options in the menu, though. There are 4 options in the original code (with 2 for adding zap timers).

Maybe it was deliberate in Onyx, but that means that the EPG mod is pretty much compulsory with it (or adding an AutoTimer becomes pretty awkward).

I just noticed in the Onyx skin (without the EPG mod) if I press the Record button in the Graphical EPG I get the popup menu, but 2 items are missing.

I changed o-channelselection.xml, making the RecordTimerQuestion screen have a height of 195, the "list" have a height of 180, and created a recordquestion4.png image with a height of 195. That seems to fix it.

KiddaC I think the background pixmap of the skin is so important it needs to be cached so should be a PNG, or alternatively don't use it for the EPG - just use a solid background colour (which is what I have at the moment).

The channel-icons section I never liked anyway, as I think it shows icons for the current TV channel showing in the PIG, not the event selected in the EPG. I found it confusing - I actually thought it was broken for ages.

Just my opinion though - I'm a bit obsessed with having a fast EPG at the moment.

I'll try to submit patches or something for the other things, once I've figured out where the best place is. (Maybe the OpenATV forum, or a github issue.)

Are you interested in performance issues of the skins?

I've been profiling the code a bit (on a ZGemma H.2S) and noticed that the background jpeg for Onyx isn't cached, so it is loaded every time it is needed, adding 0.6 seconds. PNGs are cached, so this would be quicker, although the file would be larger.

Profile for opening the graphical EPG:

ncalls  tottime  percall  cumtime  percall filename:lineno(function)
     1    0.000    0.000    2.660    2.660 /usr/lib/enigma2/python/Screens/InfoBarGenerics.py:2019(openGraphEPG)
     1    0.000    0.000    2.660    2.660 /usr/lib/enigma2/python/Screens/InfoBarGenerics.py:1993(MultiServiceEPG)
     1    0.000    0.000    2.653    2.653 /usr/lib/enigma2/python/Screens/InfoBarGenerics.py:1974(openBouquetEPG)
     1    0.000    0.000    2.653    2.653 /usr/lib/enigma2/python/StartEnigma.py:155(openWithCallback)
     1    0.001    0.001    2.653    2.653 /usr/lib/enigma2/python/StartEnigma.py:161(open)
     2    0.002    0.001    2.381    1.191 /usr/lib/enigma2/python/StartEnigma.py:125(doInstantiateDialog)
     1    0.000    0.000    2.346    2.346 /usr/lib/enigma2/python/StartEnigma.py:103(instantiateDialog)
     2    0.001    0.001    1.532    0.766 /usr/lib/enigma2/python/Screens/Screen.py:222(applySkin)
     2    0.011    0.005    1.524    0.762 /usr/lib/enigma2/python/Screens/Screen.py:246(createGUIScreen)
    77    0.007    0.000    0.875    0.011 /usr/lib/enigma2/python/skin.py:954(applyAllAttributes)
    77    0.016    0.000    0.866    0.011 /usr/lib/enigma2/python/skin.py:659(applyAll)
   411    0.022    0.000    0.850    0.002 /usr/lib/enigma2/python/skin.py:664(applyOne)
    52    0.005    0.000    0.717    0.014 /usr/lib/enigma2/python/skin.py:791(pixmap)
    52    0.006    0.000    0.711    0.014 /usr/lib/enigma2/python/skin.py:487(parsePixmap)
    85    0.008    0.000    0.703    0.008 /usr/lib/enigma2/python/Tools/LoadPixmap.py:7(LoadPixmap)
===> 1    0.653    0.653    0.653    0.653 {built-in method _enigma.loadJPG}
     2    0.004    0.002    0.628    0.314 /usr/lib/enigma2/python/skin.py:1315(readSkin)
  43/2    0.027    0.001    0.617    0.309 /usr/lib/enigma2/python/skin.py:1495(processScreen)
   119    0.121    0.001    0.560    0.005 /usr/lib/enigma2/python/Tools/Directories.py:91(resolveFilename)

2nd (and subsequent) time using a PNG instead of a JPG for the background, cuts the time down from 2.6 to 1.9 seconds:

ncalls  tottime  percall  cumtime  percall filename:lineno(function)
     1    0.000    0.000    1.911    1.911 /usr/lib/enigma2/python/Screens/InfoBarGenerics.py:2019(openGraphEPG)

Also note that it spends 0.5 seconds resolving filenames. I used a cache to help cut that too, now down to 1.4 seconds:

ncalls  tottime  percall  cumtime  percall filename:lineno(function)
     1    0.000    0.000    1.433    1.433 /usr/lib/enigma2/python/Screens/InfoBarGenerics.py:2019(openGraphEPG)

I'm still fairly new to Enigma, so I may well have missed stuff. But it might be useful.

UPDATE:

I removed the picon & "channel-icons" section from the top-right (which I don't really need) and got it under 1 second! I'm not sure why they are so slow. (I don't have picons installed.). UPDATE: It turned out that the "channel-icons" are the main problem.

ncalls  tottime  percall  cumtime  percall filename:lineno(function)
     1    0.000    0.000    0.983    0.983 /usr/lib/enigma2/python/Screens/InfoBarGenerics.py:2019(openGraphEPG)

Bouquets with lots of channels seem to slow down the opening of the EPG too. I'm going to have a look at that now.

UPDATE: It was loading the EPG data for all the channels at once, visible or not. I've changed that and it runs great now - very smooth!

I'll tidy it up a bit and maybe try to get it into OpenATV.

Quote from urie

Quote from Damon Chaplin

Quote from urie

No Such Problems here:

Yes, you probably won't notice if you have lots of bouquets, as the errors will be off the screen.

After I posted images I atually ran AautoBouquetsMaker and it rescanned and did new bouquest and removed my IPTV ones so just SKY, Freesat and Freeview and I tabbed back and forth a few times still did not notice anything.

I can see the duplicate in your screen shots but I don't have any .

That still sounds like a lot of bouquets. They have to all fit on the screen to notice the bug.

The code does look wrong as well, so unless it has been changed I do think it is a bug. But I'll leave it up to kiddac.

Quote from urie

No Such Problems here:

Yes, you probably won't notice if you have lots of bouquets, as the errors will be off the screen.

Since noone believes me, here are some screenshots! (I just didn't know how to do them before.)

In the first one it wraps around to "Entertainment" again.

In the second one "Entertainment" is missing.

Boring explanation follows:

You want newendbouqlist to include all the bouquets up to, but not including, the one at index (the one currently shown). This code does that:

newendbouqlist = self.bouquets[0:index]

If you use [0:index-1] it doesn't include the one at index-1 either (which explains the missing bouquet in the second screenshot).

And if you use [0:index-1] when when index is 0 this becomes [0:-1] which includes nearly all the list when you don't want any! (first screenshot)

I think I noticed a tiny bug in the EPG mod code (it resulted in the first bouquet being repeated at the end, or the last bouquet being omitted):

--- EpgSelection.py.orig 2023-03-15 10:29:59.478050297 +0000

+++ EpgSelection.py 2023-03-15 10:59:03.492644457 +0000

@@ -2296,7 +2296,7 @@

else:

break;

- newendbouqlist = self.bouquets[0:index-1]

+ newendbouqlist = self.bouquets[0:index]

newstartbouqlist = self.bouquets[index+1:listlength]

finalbouqlist = newstartbouqlist + newendbouqlist

It turns out the reason I couldn't change the MoviePlayer screen was that I had the Enhanced Movie Center plugin installed and it was using the screen from that instead! (That was so confusing!)

So I've disabled that, and the Onyx screen is shown now, and all works fine except the playback speed isn't shown. (I've added a simple PVRState widget back as a temporary fix.)

Quote from urie

Quote from Damon Chaplin

Quote from mo7866

I’ve just updated to open atv 7.2 and wanted to check whether others are having the same issue as me

When you click epg it brings up the graphicalepg I think it’s called. When you then press menu it shows a blank screen with no options

If you go via the set menus where all the settings are and go to the epg/graphicalepg. You can see all the options

Could someone check if they have the same issue

Display More

I think the EPG mod conflicts with atv 7.2. I removed the mod and it works OK again.

(I had to copy the original EpgSelection.py over manually.)

Display More

There are various versions of epg selection mod just say for openatv 6.4 then openatv 6.5 and now 7.xx python changes and opeatv team also keep changing things . Try this version it was last mod done by KiddaC
Personally I have since just replaced EpgSelection.py in enigma2-plugin-extensions-openatv-epgselection-mod_3.1_all.ipk with latest version because I wont be going back to openatv 6.4

Display More

Yes, that seems to fix it. Thanks.

Quote from mo7866

I’ve just updated to open atv 7.2 and wanted to check whether others are having the same issue as me

When you click epg it brings up the graphicalepg I think it’s called. When you then press menu it shows a blank screen with no options

If you go via the set menus where all the settings are and go to the epg/graphicalepg. You can see all the options

Could someone check if they have the same issue

Display More

I think the EPG mod conflicts with atv 7.2. I removed the mod and it works OK again.

(I had to copy the original EpgSelection.py over manually.)

Quote from KiddaC

This is something openatv changed lately. Never got round to testing or possible fixing it yet.
And if its different from all other oe-alliance images. Then its not getting fixed until everyone uses the same components code.

Movie player screen ... there is an option in user interface > settings > show PVR status in movie player infobar

All my skins on this forum, have a recommend settings section. You would find that info in there
RE: *UPDATED* Slyk Onyx 1080 (Install - FAQs)

I did use the recommended settings! I have "show PVR status" turned on.

I'll have a look at the code. Though I'm new to enigma so I doubt I'll find the issue. It's not that serious anyway.

UPDATE: I don't think atv 7.2 likes the Onyx MoviePlayer screen at all - I think it may be using the default screen instead, which is why my changes don't do anything. I could be wrong though.

I've spotted a few problems with the movie player screen. (Shown when you pause or fast-forward recorded movies.)

1) The time on the left sometimes disappears. Usually when there are lots of zeros in it!

( It is easy to see here if I just leave a 2-hour+ movie on double-speed.)

2) The playback speed isn't shown. (Though it isn't shown in the default skin or MetrixHD either.)

The time shift screen does show it though.

I've tried editing /usr/share/enigma2/slyk-onyx-1080/o-movies.xml to move stuff around, and restarting/rebooting but it doesn't seem to do anything so I may be looking at the wrong thing.

Damon

Zgemma H.2H, openATV 7.2.20230222 (2023-02-19),

enigma2-plugin-skins-slyk-onyx-1080_2.34.20230103_all.ipk

I can't get the main EPG to show more than 10 rows when the small TV picture is shown (i.e. "Picture in Graphics" is on).

I've been using 16 rows in an old version of Slyk on another box. Is there a reason for the limit now?

Thanks.

UPDATE: I changed NumberOfRows in /usr/share/enigma2/slyk-q-1080/q-epg.xml to 16 and that seems to work.

It should follow the settings though, shouldn't it?

Zgemma H.2H, openATV 7.2.20230222 (2023-02-19),

I've tried both enigma2-plugin-skins-slyk-onyx-1080_2.34.20230103_all.ipk

and enigma2-plugin-skins-slyk-q-1080_1.36.20230103_all.ipk